Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix prepare inputs labels for multimodal #84

Open
wants to merge 2 commits into
base: inference
Choose a base branch
from
Open

Fix prepare inputs labels for multimodal #84

wants to merge 2 commits into from

Conversation

khaimt
Copy link

@khaimt khaimt commented Jun 28, 2024

  • Add assert to make sure number of images == number of image tokens in inputs
  • Fix the case where num_images == 0:
    • We don't need to use image_features at here
    • cannot set cur_image_idx += 1 --> will run into error for many cases. For example, if batch contains 2 data points without containing images in inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@khaimt