-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual Filter Plugin Redesign #3484
Conversation
That looks good to me. 👍 |
@Umcaruje I plan on merging today if you don't have any changes 😊 |
The box size is off by 2 pixels, and the third knob's position is off by a pixel. I'll post a fixed mockup asap. |
Actually, sorry, the knob spacing is not the same on the 2 boxes, it's either 1 or 2 pixels off. It should all be on the same value and the padding of the box should be the same on both sides. |
Also do we want a line connecting the boxes like in the stereo matrix plugin? So it's clear the mix is between the two filters? |
@Umcaruje Wonderful feedback, thanks! A mockup works just fine for me. I'll play with the spacing and try your idea to connect the boxes. |
I'm merging this in 12 hours if there are no objections. |
* Dual Filter * Design Tweaks
* Dual Filter * Design Tweaks
In this pull request, I have recreated the Dual Filter plugin redesign proposed by @simonvanderveldt in #3093 as a part of our efforts here.
@Umcaruje @BaraMGB