Piano roll: reset editing mode when lost focus #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forgot to add some changes. I'll add it soon. |
|
Now it changes another behavior. If you press control key when you're in draw mode, select erase mode, and then release control key:
|
|
I'll merge this in 24 hours if no issues are reported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
m_editModeback tom_ctrlModeas if the Control key is released inPianoRoll::focusOutEvent. Fixes #4390, and partially #3833.The handler is also called when the editor is closed(in Qt, hiding focused widget generates focus out event). If this works, similar patch can be applied for song editor in
masterbranch(current fix #3796 is incomplete, it doesn't work when switching window).