-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix song editor visualization after maximizing #4698
Conversation
I get a crash introduced in 86f9a75. To reproduce.
Basically the crash happens if there is anything in the Song Editor. Just click in the project to get a TCO and click "New Project" is enough. I don't know why I didn't see this when I tested the PR.
Edit @PhysSong: Removed irrelevant part from the backtrace |
@zonkmachine Neither Qt4 nor Qt5 gives me the crash. |
Recompiled with Qt5 and it doesn't see this issue. I don't know if a recent update of my linuxmint installation could have done this. I don't think Qt4 gets any updates anywhere but maybe some native package Qt depends on was changed? I'll keep looking. If it's just me crashing we're good... ;) |
Yeah. I'm on Xenial (linuxMint 18.3) and the libx11 packages received security updates. |
Fixes #70 by overriding
changeEvent
in theSongEditorWindow
class.