Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mixer EffectRackView GUI glitch #7511

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix mixer EffectRackView GUI glitch #7511

wants to merge 3 commits into from

Conversation

Rossmaxx
Copy link
Contributor

@Rossmaxx Rossmaxx commented Sep 19, 2024 •
edited
Loading

fixes: #7508, #7510

@Rossmaxx
Copy link
Contributor Author

It seems fixed on my end. It would help if anyone else confirms the fix.

@Rossmaxx Rossmaxx mentioned this pull request Sep 19, 2024
Open
1 task
@PhysSong PhysSong linked an issue Sep 19, 2024 that may be closed by this pull request
Layout issues after SlicderT UI update #7510
Open
1 task
@zonkmachine
Copy link
Member

... #7510

This seem to fix the mixer effect chain gui but not the instrument effect chain.

@Rossmaxx
Copy link
Contributor Author

Rossmaxx commented Sep 19, 2024 •
edited
Loading

Zonk can you clarify with screenshots?

@sakertooth sakertooth mentioned this pull request Sep 19, 2024
Open
1 task
@sakertooth
Copy link
Contributor

This is the problem @zonkmachine is referring to @Rossmaxx.
image

@sakertooth
Copy link
Contributor

I don't think it was right to merge the instrument & effect chain resize changes in #7453. I feel like that PR should have been more focused on making SlicerT use the resize changes after they were implemented in another PR rather than it implementing them and then using it. It would have make reviewing a bit easier I think, and we would've had a better chance at catching these problems.

@Rossmaxx
Copy link
Contributor Author

Thanks saker, I'll look into that too.

@Rossmaxx
Copy link
Contributor Author

I tried to fix the instrument effect view getting chopped but couldn't figure out what file to actually edit. I tried a couple different files but none of those fixed it.

I'll be afk for a few days so if someone finds a fix, feel free to push to this branch and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakertooth sakertooth Awaiting requested review from sakertooth

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Layout issues after SlicderT UI update Mixer bugs and unpleasant changes
3 participants
@Rossmaxx @zonkmachine @sakertooth