Bugfix/update default plugins url #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default plugins URL responds 2 chained 301 redirections, and it seems to be causing an issue when displaying the plugins page. As they are permanent redirections, the ExtensionsManager might as well use the final value directly. The error message I had was this: Répertoire incorrect https://lms-community.github.io/lms-plugin-repository/extensions.xml - Timed out waiting for data
|
Two re-directs shouldn't be a problem. If that is timing out, then there's a different issue. This is the first time I hear about this. What OS are you running LMS on? I'd like to keep the two domains separate: the GitHub URL for technical, infrastructure URLs, Lyrion.org for user facing stuff. Just in case we'd have to split traffic at some point. |
|
LMS is running in a container on a Synology NAS, but it may have been a network security issue, I will re-check with the friend who's the one running it. |
|
Any news? Can we close this? |
|
Sorry, yes, it was a mistake in his network. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default plugins URL responds 2 chained permanent redirections, and it seems to be causing an issue when displaying the plugins page.
As they are permanent redirections, the ExtensionsManager might as well use the final value directly.
The error message I had was this, when displaying the plugins page:
Répertoire incorrect https://lms-community.github.io/lms-plugin-repository/extensions.xml - Timed out waiting for data
The URL in UNSUPPORTED_REPO is updated too, as it has the same 2x301 redirections.