Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB "decentralized geneses": contract unowned extensions & valencies implementation #112

Merged
merged 13 commits into from
Sep 30, 2020

Conversation

dr-orlovsky
Copy link
Member

See LNP-BP/LNPBPs#52 for explanations. This PR implements:

  • Schema for extensions
  • Schema validation
  • Extension implementation within RGB contracts
  • Inclusion of extension data into consignments
  • Consignments validation for extensions

@rajarshimaitra can you pls update test data to make tests not failing? And we need to add test coverage where it is missed.

@dr-orlovsky dr-orlovsky added *security* Security-related issues feature New functionality *consensus* Changes breaking existing consensus rules *scalability* Issues important for scalability labels Sep 30, 2020
@dr-orlovsky dr-orlovsky added this to the v0.1.0 Release milestone Sep 30, 2020
@rajarshimaitra
Copy link
Contributor

Noted, will work on the test updates.

@rajarshimaitra
Copy link
Contributor

Yeah. Finally managed to push it.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #112 into master will decrease coverage by 0.4%.
The diff coverage is 39.0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #112     +/-   ##
========================================
- Coverage    57.9%   57.5%   -0.4%     
========================================
  Files          59      59             
  Lines        6581    6851    +270     
========================================
+ Hits         3810    3941    +131     
- Misses       2771    2910    +139     
Impacted Files Coverage Δ
src/rgb/bech32.rs 0.0% <0.0%> (ø)
src/rgb/schema/script.rs 40.0% <0.0%> (-2.9%) ⬇️
src/rgb/stash/consignment.rs 0.0% <0.0%> (-52.8%) ⬇️
src/rgb/validation.rs 0.0% <0.0%> (-19.6%) ⬇️
src/rgb/schema/schema.rs 34.4% <36.1%> (+1.0%) ⬆️
src/rgb/schema/nodes.rs 84.7% <81.6%> (+6.0%) ⬆️
src/lnpbps/lnpbp4.rs 0.0% <0.0%> (-15.4%) ⬇️
src/rgb/stash/anchor.rs 0.0% <0.0%> (-4.7%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4377e5d...a95bca7. Read the comment docs.

@dr-orlovsky
Copy link
Member Author

dr-orlovsky commented Sep 30, 2020

@rajarshimaitra can you also pls work on adding cases to existing tests here so we would not forget it later? (I.e. don't write new tests; just add coverage for new fields when needed if the test for other fields/structures are already in place)

UPD: if this is already done, just let me know and I will merge

@dr-orlovsky dr-orlovsky self-assigned this Sep 30, 2020
@dr-orlovsky dr-orlovsky merged commit 68cc01b into master Sep 30, 2020
@dr-orlovsky dr-orlovsky linked an issue Oct 1, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*consensus* Changes breaking existing consensus rules feature New functionality *scalability* Issues important for scalability *security* Security-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network serialization for Genesis chain parameters
2 participants