You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 12, 2020. It is now read-only.
GenerateGUID doesn't actually generate a GUID--it gives a constant one. This is fine, but it's deceptive and looks random. I don't see a problem in changing it to something to where developers can easily tell its a shim (like 000000-...)
When I added this, I didn't think too much about it, but you're absolutely right about it being misleading. I think the best solution would be to actually generate something unique so that anything that depends on generated ids will actually get different values.
+1 for "actually generate something unique so that anything that depends on generated ids will actually get different values"
Probably doesn't have to be anything complicated, a counter ticking up would probably work.
Kampfkarren
changed the title
GenerateGUID shim should more obviously be constant
GenerateGUID shim should more obviously be constant or generate actual unique IDs
Nov 16, 2018
GenerateGUID doesn't actually generate a GUID--it gives a constant one. This is fine, but it's deceptive and looks random. I don't see a problem in changing it to something to where developers can easily tell its a shim (like 000000-...)
lemur/lib/instances/HttpService.lua
Line 26 in ff37c3e
The text was updated successfully, but these errors were encountered: