Skip to content

Commit

Permalink
Restore "delete principal from group" listener invocation (#5584)
Browse files Browse the repository at this point in the history
  • Loading branch information
labkey-adam authored Jun 14, 2024
1 parent d4a99b0 commit 9a638e9
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 5 additions & 0 deletions api/src/org/labkey/api/security/SecurityManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -1564,6 +1564,11 @@ public static void deleteMembers(Group group, Collection<UserPrincipal> membersT
GroupMembershipCache.handleGroupChange(group, member);
}, CommitTaskOption.IMMEDIATE, CommitTaskOption.POSTCOMMIT, CommitTaskOption.POSTROLLBACK);

transaction.addCommitTask( () -> {
for (UserPrincipal member : membersToDelete)
fireDeletePrincipalFromGroup(group.getUserId(), member);
}, CommitTaskOption.POSTCOMMIT);

if (!group.isProjectGroup())
ensureAtLeastOneRootAdminExists();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -910,9 +910,10 @@ else if (topMessage.equals("Zip bomb detected!"))
// Tika flags some files as "zip bombs"
logAsWarning(r, "Can't parse this file", rootMessage);
}
else if (topMessage.equals("Unable to unpack document stream"))
// "org.apache.commons.compress.archivers.ArchiveException: No Archiver found for the stream signature" OR
// "org.tukaani.xz.UnsupportedOptionsException: LZMA dictionary is too big for this implementation"
else if (topMessage.equals("Unable to unpack document stream") || rootMessage.equals("LZMA dictionary is too big for this implementation"))
{
// Usually "org.apache.commons.compress.archivers.ArchiveException: No Archiver found for the stream signature"
logAsWarning(r, "Can't decompress this file", rootMessage);
}
else if (StringUtils.endsWithIgnoreCase(r.getName(), ".chm"))
Expand Down

0 comments on commit 9a638e9

Please sign in to comment.