Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 51383: Update ExcelFactory to skip logging on bogus Excel file #5948

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

labkey-jeckels
Copy link
Contributor

Rationale

Bad file input doesn't need to spam the logs or mothership

Changes

  • Don't report ExcelFormatExceptions
  • Assorted code cleanup in ExcelFactory

@labkey-jeckels labkey-jeckels merged commit d206d97 into develop Oct 16, 2024
10 checks passed
@labkey-jeckels labkey-jeckels deleted the fb_51383_badExcelFile branch October 16, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants