-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNPRC Scheduler Fixes #654
SNPRC Scheduler Fixes #654
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marty,
The drag-and-drop functionality is working correctly. However, I found a few other new issues:
- When a new study day is added, the scheduled date field doesn't get updated until after the save.
- Tabbing out of the study day column moves the cursor to column 1 of the procedure note row.
- After adding a Study Day note the icon doesn't get updated until one of the check boxes is clicked.
I pushed an update that should fix #1 and #3. I'm not able to repro #2. We can discuss more in the meeting next week, but you can try out the other two when you get a chance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the one minor UI problem we talked about, everything seems to be working fine. Let's merge it and worry about the UI later.
Rationale
Recent NPM and JSON updates resulted in some issues in the SNPRC scheduler. NPM and package updates required some refactoring mostly around react-dnd. JSON library updates has subtle differences in helper functions and handling null values.
Changes