Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNPRC Scheduler Fixes #654

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

labkey-martyp
Copy link
Contributor

Rationale

Recent NPM and JSON updates resulted in some issues in the SNPRC scheduler. NPM and package updates required some refactoring mostly around react-dnd. JSON library updates has subtle differences in helper functions and handling null values.

Changes

  • Update the Drag and Drop context provider and interfaces with DraggableContainer
  • Add key to ensure ReactDataGrid wrapped in DraggableContainer re-renders on state updates
  • Use JSON.optString for strings with default to null
  • Use JSON.isNull to check both if the property exists and if it is null.

Copy link
Collaborator

@spamhurts spamhurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marty,
The drag-and-drop functionality is working correctly. However, I found a few other new issues:

  1. When a new study day is added, the scheduled date field doesn't get updated until after the save.
  2. Tabbing out of the study day column moves the cursor to column 1 of the procedure note row.
  3. After adding a Study Day note the icon doesn't get updated until one of the check boxes is clicked.

@labkey-martyp
Copy link
Contributor Author

Marty, The drag-and-drop functionality is working correctly. However, I found a few other new issues:

  1. When a new study day is added, the scheduled date field doesn't get updated until after the save.
  2. Tabbing out of the study day column moves the cursor to column 1 of the procedure note row.
  3. After adding a Study Day note the icon doesn't get updated until one of the check boxes is clicked.

I pushed an update that should fix #1 and #3. I'm not able to repro #2. We can discuss more in the meeting next week, but you can try out the other two when you get a chance.

@spamhurts spamhurts self-requested a review January 18, 2024 22:35
Copy link
Collaborator

@spamhurts spamhurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one minor UI problem we talked about, everything seems to be working fine. Let's merge it and worry about the UI later.

@labkey-martyp labkey-martyp merged commit 1a2484e into release23.11-SNAPSHOT Jan 24, 2024
3 checks passed
@labkey-martyp labkey-martyp deleted the 23.11_fb_snprc_scheduler_fixes branch January 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants