Handle Widget Modal Closing on Submit or Cancel #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tId column name by prefixing columns with snd/ehr. (#701)
RameshRapa
reviewed
Mar 21, 2024
| @@ -145,23 +162,29 @@ export const EventListingGridPanelImpl: FC<EventListingProps> = memo((props: Eve | |||
| /> | |||
| )} | |||
| {showDialog === 'edit' && ( | |||
| <ProcedureEntryModal onCancel={closeDialog} | |||
| <ProcedureEntryModal onCancel={handleCloseUpdateModal} | |||
There was a problem hiding this comment.
onCancel , we can directly closeDialog here Jay instead of calling the handleCloseUpdateModal and doing closeDialog in that handle function.
There was a problem hiding this comment.
just as you did in line 174
RameshRapa
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Issue:
Related PR: