Fixes requiring namespace when namespace variable is not set #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicle
reviewed
Aug 13, 2020
test.sh
Outdated
| @@ -1,7 +1,7 @@ | |||
| #!/bin/bash -eu | |||
|
|
|||
| echo; echo "Creating ServiceAccount..." | |||
| kubectl create sa test-user | |||
| kubectl create sa test-user --dry-run -o yaml | kubectl apply -f - | |||
There was a problem hiding this comment.
The --dry-run option has been deprecated since v1.18+, so could you replace them with --dry-run=client?
There was a problem hiding this comment.
I thought I saw some deprecation error...
Fixed them.
Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#29
Fixing namespace not set error, when kind is not ServiceAccount.
In this fix, when kind is Group, the summary for role will not be shown even if present.
In the current implementation, no summary will be shown for this corner case.
To allow summary for Group with role, the following line should be modified to add Group.
https://github.com/Ladicle/kubectl-rolesum/blob/master/cmd/cmd.go#L111
This PR do not fix this problem.