LibWeb: Don't trigger onchange event when setting <select> value

LadybirdBrowser · Oct 8, 2024 · 5d00211 · 5d00211
1 parent f88aced
commit 5d00211
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt b/Tests/LibWeb/Text/expected/HTML/HTMLSelectElement-value-change-trigger-onchange.txt
@@ -0,0 +1 @@
+  PASS
diff --git a/Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html b/Tests/LibWeb/Text/input/HTML/HTMLSelectElement-value-change-trigger-onchange.html
@@ -0,0 +1,26 @@
+<!DOCTYPE html>
+<script src="../include.js"></script>
+<select id="select-test">
+    <option value="A"></option>
+    <option value="B"></option>
+</select>
+<script>
+    asyncTest(done => {
+        const selectElement = document.getElementById("select-test");
+        let onchangeTriggered = false;
+
+        selectElement.onchange = () => {
+            onchangeTriggered = true;
+        }
+
+        selectElement.value = "B";
+        setTimeout(() => {
+            if (!onchangeTriggered) {
+                println("PASS");
+            } else {
+                println("FAILED");
+            }
+            done();
+        }, 1);
+    });
+</script>
diff --git a/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp b/Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
@@ -295,7 +295,6 @@ WebIDL::ExceptionOr<void> HTMLSelectElement::set_value(String const& value)
     for (auto const& option_element : list_of_options())
         option_element->set_selected(option_element->value() == value);
     update_inner_text_element();
-    queue_input_and_change_events();
     return {};
 }