-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appkit+Qt+LibWeb+LibWebView: Dock inspector in browser window #1438
base: master
Are you sure you want to change the base?
Conversation
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
ccfabe3
to
a8f134d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Welcome to Ladybird. :^)
This is a cool feature, thanks for working on it!
I must admit that objective-c is still a mystery to me, and I'm not that familiar with Qt either, so those changes will need someone else to review.
Most of my comments are about commit style really - generally I think this is good. When correcting a change you made earlier in the same PR, please make that correction to the original commit. You can find a good guide to doing that here, or ask for help here or on Discord if you get stuck. (Git is very good at letting you undo mistakes, it's just bad at making it clear how to do so.)
bc15005
to
41c43d9
Compare
41c43d9
to
acc2cd0
Compare
@AtkinsSJ Thanks for the review! I cleaned up the commits and addressed your comments |
acc2cd0
to
2425b79
Compare
2425b79
to
c8815df
Compare
Description
This PR allows for the inspector to be docked in the window beside the web content. There are some issues with the
<select/>
tag dropdowns that are within the inspector but didn't address them as they were out of scope for this feature.This PR also sets the ground work to have up, down, left, right and windowed inspector positions in a
<select/>
within the inspector and also have the browser remember what the last size and position that inspector was in last which I hope to follow up this PR withAppkit
VideoSmaller.Sept.19.Screen.Recording.mov
Qt
VideoSmaller.Screen.Recording.Sept.19.mov