Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appkit+Qt+LibWeb+LibWebView: Dock inspector in browser window #1438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

neil-ptr
Copy link

@neil-ptr neil-ptr commented Sep 19, 2024

Description

This PR allows for the inspector to be docked in the window beside the web content. There are some issues with the <select/> tag dropdowns that are within the inspector but didn't address them as they were out of scope for this feature.

This PR also sets the ground work to have up, down, left, right and windowed inspector positions in a <select/> within the inspector and also have the browser remember what the last size and position that inspector was in last which I hope to follow up this PR with

Appkit

VideoSmaller.Sept.19.Screen.Recording.mov

Qt

VideoSmaller.Screen.Recording.Sept.19.mov

@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@neil-ptr neil-ptr force-pushed the docked-inspector branch 4 times, most recently from ccfabe3 to a8f134d Compare September 19, 2024 19:59
Copy link
Member

@AtkinsSJ AtkinsSJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Welcome to Ladybird. :^)

This is a cool feature, thanks for working on it!

I must admit that objective-c is still a mystery to me, and I'm not that familiar with Qt either, so those changes will need someone else to review.

Most of my comments are about commit style really - generally I think this is good. When correcting a change you made earlier in the same PR, please make that correction to the original commit. You can find a good guide to doing that here, or ask for help here or on Discord if you get stuck. (Git is very good at letting you undo mistakes, it's just bad at making it clear how to do so.)

Ladybird/AppKit/UI/InspectorWindow.h Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorWindow.mm Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorController.mm Outdated Show resolved Hide resolved
Userland/Libraries/LibWebView/WebContentClient.cpp Outdated Show resolved Hide resolved
Base/res/ladybird/inspector.js Outdated Show resolved Hide resolved
Ladybird/AppKit/UI/Inspector.h Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorController.h Outdated Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorController.mm Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorController.h Outdated Show resolved Hide resolved
Ladybird/AppKit/UI/InspectorController.mm Outdated Show resolved Hide resolved
@neil-ptr neil-ptr force-pushed the docked-inspector branch 7 times, most recently from bc15005 to 41c43d9 Compare September 25, 2024 04:00
@neil-ptr
Copy link
Author

@AtkinsSJ Thanks for the review! I cleaned up the commits and addressed your comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants