LibWeb: Define PerformanceEventTiming #1490
Open
+217
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahmbright
force-pushed
the
performance_event
branch
from
127b7d3
to
3f58740
Compare
https://www.w3.org/TR/event-timing/#sec-performance-event-timing Add idl, header and stubs for PerformanceEventTiming interface. Two missing `PerformanceEntry` types that have come up in issues are the `first-input` and the `event` entryTypes. Those are both this. Also, because both of those are this same interface, the static methods from the parent class are difficult to implement because of instance-specific details. Might either need subclasses or to edit the parent and also everything that inherits from it :/
noahmbright
force-pushed
the
performance_event
branch
from
3f58740
to
d879f35
Compare
|
|
||
| // https://www.w3.org/TR/event-timing/#sec-init-event-timing | ||
| PerformanceEventTiming::PerformanceEventTiming(JS::Realm& realm, String const& name, HighResolutionTime::DOMHighResTimeStamp start_time, HighResolutionTime::DOMHighResTimeStamp duration, | ||
| DOM::Event event, HighResolutionTime::DOMHighResTimeStamp processing_start, unsigned long long interaction_id) |
There was a problem hiding this comment.
Wait, how are we taking a DOM::Event by value here? It inherits from JS::Cell which is noncopyable. What's going on?
There was a problem hiding this comment.
I can't explain why this compiles, but I can file an issue and change this to a DOM:: Event const&, which was an oversight on my part anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/event-timing/#sec-performance-event-timing
Add idl, header and stubs for PerformanceEventTiming interface.
Two missing
PerformanceEntrytypes that have come up in issues are thefirst-input(#226) and theevent(#1298) entryTypes. Those are both this.Also, because both of those are this same interface, the static methods from the parent class are difficult to implement because of instance-specific details. Might either need subclasses or to edit the parent and also everything that inherits from it :/