GN fixes and initial work for Windows #1517
Draft
+35
−536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the build rules for GN to bring the library list in sync partially by removing libraries which no longer exist in the tree. This is required to make forward progress on building with GN (with the hope of using this to build for Windows).
This file seems to be removed from the source tree. Remove the associated data processing for the build.
This library is not built with GN yet, so remove the reference.
These are no longer in the tree, remove the references to them and the use of them.
These libraries referenced files which no longer are present in the source tree preventing an initial run of ninja to identify commands. Update them to match the current tree layout. With this, we can get `ninja -C Build\ladybird` to start.
This updates the environment variables that are passed along to the tool to run this build command.
The build assumed QT or AppKit are the only build UI frameworks. This extends the default assumption away from that to start experimenting with building on other platforms.
The file is not committed to disk until the close which occurs at the termination of the scope. Extract the `rename` to outside the scope allowing this to work on Windows.
|
CC: @ADKaster who is working on a similar set of changes |
|
Ha! I do happen to have most of these changes either in my branch or locally. Major difference being renaming LibProtocol to LibRequests (which is the change I actually made) rather than removing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.