LibWeb: Make horizontal scrollbar start from the left edge of viewport #1529
Conversation
Horizontal scrollbar has to leave space at right edge for the vertical scrollbar to fully extend from top-to-bottom edge of viewport. Before, this was done by just moving it leftward beyond the edge of viewport. Now, it gets scaled down appropriately to fit between left edge of viewport & vertical scrollbar without clipping.
| if (scroll_overflow_size == 0) | ||
| return {}; | ||
|
|
||
| auto min_thumb_length = min(scrollport_size, 24); | ||
| auto thumb_length = max(scrollport_size * (scrollport_size / scroll_overflow_size), min_thumb_length); | ||
| auto scrollbar_rect_length = is_horizontal ? scrollport_size - scrollbar_thumb_thickness : scrollport_size; |
There was a problem hiding this comment.
why scrollbar_thumb_thickness is subtracted only for horizontal thumb? wouldn't we need the same for vertical?
There was a problem hiding this comment.
Yes, only if you leave an empty square at the bottom-right corner where both scrollbars meet. I'm not doing that. Vertical scrollbar has no changes in this patch. Only the horizontal scrollbar is getting changes here.
|
could you provide html or url improved by this change so we could verify it works? I tried some websites but horizontal thumb looked correct there. |
|
See the screenshots: before, in the If the thickness is 5% and viewport width is 100%, before horizontal scrollbar is 100% wide and starts at -5% and ends at 95%. Now, it starts at 0% and ends at 95%. |
Before:
After: