LibWeb: implement navigator.maxTouchPoints #1536
Conversation
| #if defined(AK_OS_MACOS) | ||
| int max_touch_points = 1; | ||
| return max_touch_points; | ||
| #elif defined(AK_OS_LINUX) | ||
| int max_touch_points = 20; | ||
| return max_touch_points; | ||
| #else | ||
| return 0; | ||
| #endif |
There was a problem hiding this comment.
I don't believe it's sufficient to return an arbitrary number based on the platform like this. The number returned should depend on the underlying hardware of the given machine. For example, Chrome returns 10 on my touchscreen laptop, but 0 on my desktop. If we can't figure out what is supported by the hardware then I think the best thing to do is to return 0, which implies that touch input is not supported.
ChaseKnowlden
force-pushed
the
maxtouchpoints
branch
from
e275b56
to
123866e
Compare
There's no sense in adding a Windows implementation, as we can't build the application for windows. |
ChaseKnowlden
force-pushed
the
maxtouchpoints
branch
from
0557fd9
to
6ad0e77
Compare
|
Mac computers don't even have touch screens. |
ChaseKnowlden
force-pushed
the
maxtouchpoints
branch
from
6ad0e77
to
bf44727
Compare
ChaseKnowlden
force-pushed
the
maxtouchpoints
branch
from
bf44727
to
ba506e2
Compare
If you plug in a graphics tablet or other touchscreen, that should be included I think. We need to ask the OS about it. |
|
I've added the code to check touch screen or trackpad support on macOS. |
|
Will cause merge conflict after #2256 is merged. |
|
Apparently rebasing is enough to make it work |
This is needed by vercel.com to determine how many touch points there is.
For #1298