LibJS: Make function instantiation a bit more spec compliant #1555
+207
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo: seperate -> separate A valuable optimization we should do is moving everything immutable from This would make instantiation much faster, since we could reuse all the shared data instead of recomputing it. :) |
Implement "10.2.5 MakeConstructor" as per the ecma262 spec
Arrange the instantiation of different JS function types into separate functions that meet the ECMA262 specs.
Use the more spec compliant instantiate_function_object instead of ECMAScriptFunctionObject::create() where applicable.
Cache prototype shapes and use them when instantiating a new function object instead of creating a new one on each instantiation.
mobounya
force-pushed
the
feat-js_function_instantiation
branch
from
89baaa4
to
67a0a2d
Compare
|
@awesomekling is there anything else that we can cache in |
|
have you checked how this change affects test262? |
|
@kalenikaliaksandr I've included the test262 diff |
|
Apparently what I thought are improvement to the test262 results are just my machine being slow at times and fast at times, so no changes to the test262 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to call
ECMAScriptFunctionObject::create()to instantiate different types of JS functions with a lot of "prep" hidden inECMAScriptFunctionObject::initialize(). This replaces that withinstantiate_function_object()which matches the specs and organizes function initialization in one place.To be safe I choose to skip the code in
ECMAScriptFunctionObject::initialize()if we're instantiation from ainstantiate_function_object()otherwise that code will be executed sinceECMAScriptFunctionObject::create()is called from a bunch of other places that may need it. I think ideally that code should be removed and JS function initialization should be done from functions that match the specs.test262 diff: