Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/Layout: Implement justify-content for column spacing in grid #1593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neil-ptr
Copy link

@neil-ptr neil-ptr commented Oct 2, 2024

Description

Before, we were only adding gap tracks if the css property gap: ... had an explicit property. This PR makes sure we always add gap tracks between column tracks (as well as gaps between row tracks). Also, this implements extra space distribution to column gaps as specified in justify-content for space-around, space-between and space-evenly

@AtkinsSJ
Copy link
Member

AtkinsSJ commented Oct 2, 2024

Hi! Welcome to Ladybird. :^)

Please add a layout test that demonstrates this. (So, it fails without this change, and passes with it.) You can find examples in Tests/LibWeb/Layout. Put the HTML file in Tests/LibWeb/Layout/input/grid somewhere, and then run Tests/LibWeb/rebaseline-libweb-test /absolute/path/to/your/test/file.html to generate the output for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants