-
-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb/CSS: Define writing-mode #1601
base: master
Are you sure you want to change the base?
Conversation
Thanks for fixing the FIXME! The Can we get a test for the FIXME change? |
f9c304a
to
0810410
Compare
Yeah absolutely. We might need to detour to #398 though first 😅 Even just trying to add a dummy test locally I get timeout issue. Is there another test I can try to model off of in this area of the code? With testing a box width and what not |
0810410
to
56e8201
Compare
56e8201
to
2fd96e6
Compare
2fd96e6
to
9a18c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please separate into individual commit the change that introduces support for writing-mode property from the change in layout code.
Noticing that even though this passes CI, when I run the test suite locally Edit, it passes now. Not sure what this might have been about |
cb082cf
to
47783ed
Compare
86c0a9e
to
9e2ff2b
Compare
9e2ff2b
to
37abaf0
Compare
Fill out the json and associated boilerplate for the
writing-mode
property, and fill out a FIXME inBlockFormattingContext.cpp