Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb/CSS: Define writing-mode #1601

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

noahmbright
Copy link
Contributor

Fill out the json and associated boilerplate for the writing-mode property, and fill out a FIXME in BlockFormattingContext.cpp

@AtkinsSJ
Copy link
Member

AtkinsSJ commented Oct 2, 2024

Thanks for fixing the FIXME!

The getComputedStyle-print-all.html test fails on CI, probably someone else added a property since you last pulled master. Rebase, rebuild Ladybird, and then run that rebaseline script again to fix it.

Can we get a test for the FIXME change?

@noahmbright noahmbright force-pushed the writing_mode branch 2 times, most recently from f9c304a to 0810410 Compare October 2, 2024 16:34
@noahmbright
Copy link
Contributor Author

Can we get a test for the FIXME change?

Yeah absolutely. We might need to detour to #398 though first 😅 Even just trying to add a dummy test locally I get timeout issue. Is there another test I can try to model off of in this area of the code? With testing a box width and what not

Copy link
Member

@kalenikaliaksandr kalenikaliaksandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please separate into individual commit the change that introduces support for writing-mode property from the change in layout code.

@noahmbright
Copy link
Contributor Author

noahmbright commented Oct 6, 2024

Noticing that even though this passes CI, when I run the test suite locally /ladybird/Tests/LibWeb/Text/input/DOM/FormAssociatedElement-selection-type-change.html times out. It makes a call to getBoundingClientRect(); from an element object but I can't trace that back to the function I edited. Can anyone reproduce?

Edit, it passes now. Not sure what this might have been about

@noahmbright noahmbright force-pushed the writing_mode branch 2 times, most recently from 86c0a9e to 9e2ff2b Compare October 8, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants