AK: Address MSVC/Windows portability for logging #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`STDERR_FILENO` is pretty common but not part of the standard. On Windows, in order to get a file number, one must use `_fileno` to convert the `FILE *` to a file number. Adopt this pattern similar to the Android path which uses platform specific operations.
|
CC: @ADKaster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STDERR_FILENOis pretty common but not part of the standard. On Windows, in order to get a file number, one must use_filenoto convert theFILE *to a file number. Adopt this pattern similar to the Android path which uses platform specific operations.