Make oldFields mapping hardcoded to speed up system #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapping came with Magneto 1.6 to provide a backward compatibility for old (pre 1.6) db field names. Now the mapping is hardcoded in the class instead of saved in the configuration. This improves performance as Magento will not create tons of objects for every new product/order/... entities. Related: OpenMage#920
gocom
approved these changes
Apr 17, 2020
|
Only issue could be if some module uses this to alias fields, in which case those modules break. Maybe this could use a statistically bound proxy class instead? Would still allow configuring aliases, but doesn't init config on each entity instance. Oh boy, the places where modern DI would be very helpful, because now we would need to store and hard-code it into the entities or the proxy pool that stores the mapping. |
aapokiiso
approved these changes
Apr 18, 2020
NikoGrano
pushed a commit
that referenced
this pull request
Dec 16, 2021
…nMage#1403) * TypeError: round(): Argument #1 ($num) must be of type int|float
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping came with Magneto 1.6 to provide a backward compatibility
for old (pre 1.6) db field names.
Now the mapping is hardcoded in the class instead of saved
in the configuration.
This improves performance as Magento will not create tons of objects for
every new product/order/... entities.
Related: OpenMage#920