Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Improves CI #28

Merged
merged 23 commits into from
Jul 26, 2022
Merged

[1.x] Improves CI #28

merged 23 commits into from
Jul 26, 2022

Conversation

DarkGhostHunter
Copy link
Contributor

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #28 (62e8bc8) into 1.x (43b825c) will increase coverage by 0.26%.
The diff coverage is 100.00%.

❗ Current head 62e8bc8 differs from pull request most recent head 50e9de7. Consider uploading reports for the commit 50e9de7 to get more accurate results

@@             Coverage Diff              @@
##                1.x      #28      +/-   ##
============================================
+ Coverage     99.47%   99.73%   +0.26%     
  Complexity      135      135              
============================================
  Files            18       18              
  Lines           382      381       -1     
============================================
  Hits            380      380              
+ Misses            2        1       -1     
Impacted Files Coverage Δ
src/Models/Concerns/HandlesRecoveryCodes.php 100.00% <ø> (ø)
src/Models/TwoFactorAuthentication.php 100.00% <ø> (ø)
src/Rules/Totp.php 100.00% <ø> (ø)
src/TwoFactorLoginHelper.php 97.72% <ø> (+2.17%) ⬆️
src/TwoFactorServiceProvider.php 100.00% <ø> (ø)
src/Models/Concerns/HandlesCodes.php 100.00% <100.00%> (ø)
src/Models/Concerns/SerializesSharedSecret.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43b825c...50e9de7. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DarkGhostHunter DarkGhostHunter merged commit ed20296 into 1.x Jul 26, 2022
@DarkGhostHunter DarkGhostHunter deleted the feat/improve-ci branch July 26, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants