Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to a controlled file input #388

Merged
merged 17 commits into from
Sep 21, 2021
Merged

Refactor to a controlled file input #388

merged 17 commits into from
Sep 21, 2021

Commits on Oct 11, 2019

  1. Initial proof-of-concept

    @chawes13
    chawes13 committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    9fe36d8 View commit details
    Browse the repository at this point in the history

  2. Clean up logic and add dev hints via prop types

    @chawes13
    chawes13 committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    f349e9e View commit details
    Browse the repository at this point in the history

  3. Always return an array

    @chawes13
    chawes13 committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    fc076a0 View commit details
    Browse the repository at this point in the history

  4. Read files synchronously to avoid overwrites

    @chawes13
    chawes13 committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    32fbdde View commit details
    Browse the repository at this point in the history

  5. Modify markup to allow for focus styling

    @chawes13
    chawes13 committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    e0d1ec3 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2019

  1. Code review feedback

    @chawes13
    chawes13 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    367f116 View commit details
    Browse the repository at this point in the history

  2. Make cloudinary accept a file input and set the response appropriately

    @chawes13
    chawes13 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    864974b View commit details
    Browse the repository at this point in the history

  3. Extract helpers into shared folder

    @chawes13
    chawes13 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    25b0c50 View commit details
    Browse the repository at this point in the history

  4. Override read files utility and clean up based on code review

    @chawes13
    chawes13 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    a7dac14 View commit details
    Browse the repository at this point in the history

  5. filter invalid props from getting passed to error label (incl. label … 

    …= false)
    @chawes13
    chawes13 committed Oct 14, 2019
    Configuration menu
    Copy the full SHA
    9235b96 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Return files on cloudinary read

    @chawes13
    chawes13 committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    4eb491f View commit details
    Browse the repository at this point in the history

  2. Code clean-up

    @chawes13
    chawes13 committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    997e117 View commit details
    Browse the repository at this point in the history

  3. Update CloudinaryFileInput docs

    @chawes13
    chawes13 committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    8cac28d View commit details
    Browse the repository at this point in the history

  4. Update FileInput docs

    @chawes13
    chawes13 committed Oct 15, 2019
    Configuration menu
    Copy the full SHA
    6a41fe6 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Bump size limit

    @chawes13
    chawes13 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    7b1bfc0 View commit details
    Browse the repository at this point in the history

  2. Bump to milestone

    @chawes13
    chawes13 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    9eb2a21 View commit details
    Browse the repository at this point in the history

  3. Fix failing specs

    @chawes13
    chawes13 committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    59b9a6d View commit details
    Browse the repository at this point in the history