Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FlashMessage dependency on redux-flash #446

Merged
merged 6 commits into from
Sep 30, 2020
Merged

Remove FlashMessage dependency on redux-flash #446

merged 6 commits into from
Sep 30, 2020

Conversation

dpikt
Copy link
Contributor

@dpikt dpikt commented Sep 28, 2020

Resolves #415. FlashMessageContainer has been left as-is for backwards compatibility with the current client template.

@dpikt dpikt requested a review from chawes13 September 28, 2020 22:28
@dpikt dpikt temporarily deployed to lp-components-pr-446 September 28, 2020 22:32 Inactive
migration-guides/v5.0.0.md Outdated Show resolved Hide resolved
src/indicators/flash-message.js Outdated Show resolved Hide resolved
src/indicators/flash-message.js Outdated Show resolved Hide resolved
Copy link
Contributor

@chawes13 chawes13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dpikt dpikt merged commit f1b2695 into master Sep 30, 2020
@dpikt dpikt deleted the flash-shape branch September 30, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on redux-flash
3 participants