Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labeled field updates #595

Merged
merged 53 commits into from
Feb 13, 2024
Merged

Labeled field updates #595

merged 53 commits into from
Feb 13, 2024

Commits on Aug 1, 2023

  1. Allows LabeledField to accept optional as prop and updates Checkbox+R… 

    …adio Group
    @jhp0621
    jhp0621 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    d868e51 View commit details
    Browse the repository at this point in the history

  2. Uses css to visually hide label if set to false for Checkbox+Radio Gr… 

    …oups to preserve html semantics
    @jhp0621
    jhp0621 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    3fa079b View commit details
    Browse the repository at this point in the history

  3. Displays required indicator and hint if provided

    @jhp0621
    jhp0621 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    49debb5 View commit details
    Browse the repository at this point in the history

  4. Updates dropdown-checkbox-group to match the same semantics as regula… 

    …r checkbox-group
    @jhp0621
    jhp0621 committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9873164 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Merge branch 'main' of https://github.com/LaunchPadLab/lp-components … 

    …into labeled-field-updates
    @jhp0621
    jhp0621 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    2dc1661 View commit details
    Browse the repository at this point in the history

  2. Remove dropdown-checkbox-group component

    @jhp0621
    jhp0621 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f71254b View commit details
    Browse the repository at this point in the history

  3. Add Dropdown in storybook

    @jhp0621
    jhp0621 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    950cd7d View commit details
    Browse the repository at this point in the history

  4. Remove unused css files

    @jhp0621
    jhp0621 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4d1c06c View commit details
    Browse the repository at this point in the history

  5. Update styling

    @jhp0621
    jhp0621 committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    036cf6d View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Define checkbox group container outside of component

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4fbc017 View commit details
    Browse the repository at this point in the history

  2. Remove test suite re: missing legend

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8c73fc3 View commit details
    Browse the repository at this point in the history

  3. Set group role on labeled field and simplify classname logic

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    c2df5fe View commit details
    Browse the repository at this point in the history

  4. Move dropdown test suite into checkbox-group test file

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    04015e1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into labeled-field-updates

    @jhp0621
    jhp0621 authored Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e462dbb View commit details
    Browse the repository at this point in the history

  6. Update comment

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4a7ee8c View commit details
    Browse the repository at this point in the history

  7. Update version

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    4be9338 View commit details
    Browse the repository at this point in the history

  8. Update helper comment

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    62fd746 View commit details
    Browse the repository at this point in the history

  9. Undo defining variable outside

    @jhp0621
    jhp0621 committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    23ffe8a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. use prepare for yarn run build

    @jhp0621
    jhp0621 committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ed0cf8e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. update comments

    Ji Hye Park authored and Ji Hye Park committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    c8352b9 View commit details
    Browse the repository at this point in the history

  2. explicitly set true on useDropdown

    Ji Hye Park authored and Ji Hye Park committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    071721e View commit details
    Browse the repository at this point in the history

  3. update select component to use fieldset and legend

    Ji Hye Park authored and Ji Hye Park committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    0d2d6ab View commit details
    Browse the repository at this point in the history

  4. update tests to use test id for labeled field component

    Ji Hye Park authored and Ji Hye Park committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    4e36817 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into labeled-field-updates

    Ji Hye Park authored and Ji Hye Park committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    2a74019 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. undo updates in select

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    f1f35d5 View commit details
    Browse the repository at this point in the history

  2. rename prop

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e6fe0f7 View commit details
    Browse the repository at this point in the history

  3. use option.value for key

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    eadf88b View commit details
    Browse the repository at this point in the history

  4. update test

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    490b9e9 View commit details
    Browse the repository at this point in the history

  5. add dropdown checkboxgroup tests

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    e57ea98 View commit details
    Browse the repository at this point in the history

  6. add test units for updated legend

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9fdab57 View commit details
    Browse the repository at this point in the history

  7. rename prop rename

    Ji Hye Park authored and Ji Hye Park committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    ee51287 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. update proptype

    Ji Hye Park authored and Ji Hye Park committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    3d47b42 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. add migration guide

    Ji Hye Park committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    259978d View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. use shorthand assignment

    Ji Hye Park authored and Ji Hye Park committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ea1f920 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. add & update migration guide

    Ji Hye Park authored and Ji Hye Park committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    85ac007 View commit details
    Browse the repository at this point in the history

  2. use describe

    Ji Hye Park authored and Ji Hye Park committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    8ad9171 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. conditionally set field-wrapper class name and remove data-testid

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    dbf4ee8 View commit details
    Browse the repository at this point in the history

  2. add visually hidden class assertion

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    0844385 View commit details
    Browse the repository at this point in the history

  3. replace example in test to use grouped elements

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    a3bdda3 View commit details
    Browse the repository at this point in the history

  4. update param sentence

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    598efdc View commit details
    Browse the repository at this point in the history

  5. be explicit with allowed proptypes for wrapper element

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    cc3b562 View commit details
    Browse the repository at this point in the history

  6. fix typo

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    63514b0 View commit details
    Browse the repository at this point in the history

  7. use markup for components

    Ji Hye Park authored and Ji Hye Park committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    952d3dd View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. pass in is-active conditional classname on higher level

    Ji Hye Park committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    efa4fc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. update dropdown select so the labels populate

    Ji Hye Park authored and Ji Hye Park committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d587379 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2024

  1. Add a section about dropdown selection changes in migration guide

    @jhp0621
    jhp0621 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    f6da097 View commit details
    Browse the repository at this point in the history

  2. Update comments

    @jhp0621
    jhp0621 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    2f4dc31 View commit details
    Browse the repository at this point in the history

  3. wrap tests under describe

    @jhp0621
    jhp0621 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    bcb4729 View commit details
    Browse the repository at this point in the history

  4. Use the correct labels for dropdown test

    @jhp0621
    jhp0621 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    9814f6b View commit details
    Browse the repository at this point in the history

  5. Pass in id for checkbox label that matches input id

    @jhp0621
    jhp0621 committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    6b9c6cf View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2024

  1. Merge branch 'main' into labeled-field-updates

    @chawes13
    chawes13 authored Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c687232 View commit details
    Browse the repository at this point in the history

  2. Use labels for safe guard check

    @jhp0621
    jhp0621 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    c0dd1e7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'labeled-field-updates' of https://github.com/LaunchPadL… 

    …ab/lp-components into labeled-field-updates
    @jhp0621
    jhp0621 committed Feb 12, 2024
    Configuration menu
    Copy the full SHA
    5fb9bb7 View commit details
    Browse the repository at this point in the history