Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement base layout #12

Merged
merged 37 commits into from
Nov 4, 2020
Merged

Implement base layout #12

merged 37 commits into from
Nov 4, 2020

Conversation

LauraBeatris
Copy link
Owner

@LauraBeatris LauraBeatris commented Nov 3, 2020

This PR implements the base layout, which is the Header and Footer components.

Screenshot from 2020-11-04 12-02-18

Screenshot from 2020-11-04 12-02-33

Screenshot from 2020-11-04 12-02-49

Screenshot from 2020-11-04 12-03-04

@vercel
Copy link

vercel bot commented Nov 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/laurabeatriserafim/floripamais/nnmbaziwx
✅ Preview: https://floripamais-git-base-layout.laurabeatriserafim.vercel.app

@LauraBeatris LauraBeatris linked an issue Nov 3, 2020 that may be closed by this pull request
2 tasks

const App: React.FC<AppProps> = ({ Component, pageProps }) => (
<>
<Head>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<link href="https://fonts.googleapis.com/css2?family=Montserrat:wght@300;500;600&display=swap" rel="stylesheet" />
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed the self-hosted fonts since they aren't working - I still don't know why

But it's important to check if the fonts are taking too long to download and if it is - Let's try to solve the issue with the self-hosted fonts

@LauraBeatris
Copy link
Owner Author

Should add an animation for the mobile navbar - Maybe we can use react-spring here?

@LauraBeatris
Copy link
Owner Author

Should add an animation for the mobile navbar - Maybe we can use react-spring here?

framer-motion seems also to solve the problem https://www.framer.com/api/motion/animate-presence/

@LauraBeatris
Copy link
Owner Author

Should add an animation for the mobile navbar - Maybe we can use react-spring here?

framer-motion seems also to solve the problem framer.com/api/motion/animate-presence

Done on 71664d7

@LauraBeatris
Copy link
Owner Author

LauraBeatris commented Nov 4, 2020

The styles aren't being purged correctly... For instance, the bg-black is being used and shouldn't be purged.

  • Is the config on tailwind.config.js correctly?
  • Is it being set dynamically and that's why it's being purged? I don't think so since the footer isn't dynamic at all and the styles of it are being purged too.

@LauraBeatris
Copy link
Owner Author

The styles aren't being purged correctly... For instance, the bg-black is being used and shouldn't be purged.

Is the config on tailwind.config.js correctly?
Is it being set dynamically and that's why it's being purged? I don't think so since the footer isn't dynamic at all and the styles of it are being purged too.

Fixed on 26bcd71

@LauraBeatris
Copy link
Owner Author

The styles aren't being purged correctly... For instance, the bg-black is being used and shouldn't be purged.

Is the config on tailwind.config.js correctly?
Is it being set dynamically and that's why it's being purged? I don't think so since the footer isn't dynamic at all and the styles of it are being purged too.

The extensions were wrong. It should purge files with the following extensions: js, jsx, ts, tsx

In production, it wasn't finding any files with tsx and that's why the styles were being purged

@LauraBeatris LauraBeatris merged commit 45e02f7 into main Nov 4, 2020
@LauraBeatris LauraBeatris deleted the base-layout branch November 4, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement base layout
1 participant