reflecting to have same type as in GodotSteam #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution, I really need to get through the remaining classes again, I've developed a relatively nice workflow to cross-reference the docs + the generated stubs with more common C# data types but there are some instances where I didn't follow it through yet due to changing workflows within the first batch. |
LauraWebdev
added
good first issue
|
No worries I didn't do it all of it since some might need change inside GodotSteam too since GameServer code is missing and other neat functions. (Like you cannot get the lobbyID when sending a LobbyUpdate, seems like GodotSteam forgot about that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions not have same type as it should be in c++ side.
And chaning ulong in one place and changing it to long was confusing