-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Asymptote diagrams #61
Support Asymptote diagrams #61
Conversation
Thank you for your contribution! Can you also modify the continuous integration script to install Asymptote? You'll also need to modify the 'integration tests' step to test pandoc-plot on |
The CI issues are with Python Bokeh. |
@LaurentRDC I have added installation instructions for Asymptote using apt-get on Linux, Chocolatey on Windows, and Homebrew on MacOS. Please let me know if it runs :-) |
It seems that Asymptote works on all platforms. If you approve this and #62, I may check how much to add to MacOS tests that would still work. |
Please merge! |
|
Previous round of tests was success with Asymptote on Mac: |
Since |
I'm not merging until all the CI tests pass. I committed earlier today and the tests all passed. Therefore, the source of breakage is in this PR. Looks like some versions toolkits (e.g.MATLAB and ggplot2) installed in Github CI specifically don't support all save formats. E.g. I can save SVGs in MATLAB on my laptop, but apparently not in GitHub CI. Therefore, your update to the tests is too optimistic. If you undo that change, I think the CI tests will all pass |
Thanks for feedback! I agree that I should undo CI changes, and ensure all tests pass. |
@@ -120,13 +124,22 @@ jobs: | |||
dot -c | |||
|
|||
choco install --yes --no-progress gnuplot | |||
#refreshenv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove commented-out commands?
This is looking really good. I've made one last comment to clean up the PR a bit and remove CI debugging commands. Once that's done, I'll merge your PR. |
I'll be cleaning up the PR directly in the master branch. Thank you for your contribution! |
Fixes #55 by adding supported for Asymptote.