Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Asymptote diagrams #61

Merged
merged 19 commits into from
Oct 25, 2023

Conversation

mgajda
Copy link
Contributor

@mgajda mgajda commented Sep 8, 2023

Fixes #55 by adding supported for Asymptote.

@LaurentRDC
Copy link
Owner

Thank you for your contribution!

Can you also modify the continuous integration script to install Asymptote? You'll also need to modify the 'integration tests' step to test pandoc-plot on issue55.md

@mgajda
Copy link
Contributor Author

mgajda commented Sep 11, 2023

The CI issues are with Python Bokeh.
I could not find an asymptote installation GitHub action, so it is hard to test.

@mgajda
Copy link
Contributor Author

mgajda commented Sep 11, 2023

@LaurentRDC I have added installation instructions for Asymptote using apt-get on Linux, Chocolatey on Windows, and Homebrew on MacOS.

Please let me know if it runs :-)

@mgajda
Copy link
Contributor Author

mgajda commented Sep 12, 2023

It seems that Asymptote works on all platforms.

If you approve this and #62, I may check how much to add to MacOS tests that would still work.

@mgajda
Copy link
Contributor Author

mgajda commented Sep 13, 2023

Please merge!

@mgajda mgajda mentioned this pull request Sep 13, 2023
@mgajda
Copy link
Contributor Author

mgajda commented Sep 13, 2023

  1. I have added testing of all output formats for all available toolkits.
  2. I have added declaring output format for Asymptote: PDF, EPS, and PNG work.
  3. Unfortunately SVG, JPG output do not work in default Debian installation due to stringent ImageMagick security policy.

@mgajda
Copy link
Contributor Author

mgajda commented Sep 13, 2023

Previous round of tests was success with Asymptote on Mac:
https://github.com/LaurentRDC/pandoc-plot/actions/runs/6174543606/job/16759375009?pr=61#step:20:175
Unfortunately the executables are undetected on Ubuntu and Windows. For unknown reasons.

@mgajda
Copy link
Contributor Author

mgajda commented Sep 13, 2023

Since asymptote tests work now, I suggest we merge this, and I continue fighting CI in a separate PR.

@LaurentRDC
Copy link
Owner

I'm not merging until all the CI tests pass.

I committed earlier today and the tests all passed. Therefore, the source of breakage is in this PR.

Looks like some versions toolkits (e.g.MATLAB and ggplot2) installed in Github CI specifically don't support all save formats. E.g. I can save SVGs in MATLAB on my laptop, but apparently not in GitHub CI. Therefore, your update to the tests is too optimistic.

If you undo that change, I think the CI tests will all pass

@mgajda
Copy link
Contributor Author

mgajda commented Sep 14, 2023

Thanks for feedback!

I agree that I should undo CI changes, and ensure all tests pass.

@@ -120,13 +124,22 @@ jobs:
dot -c

choco install --yes --no-progress gnuplot
#refreshenv
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove commented-out commands?

@LaurentRDC
Copy link
Owner

This is looking really good. I've made one last comment to clean up the PR a bit and remove CI debugging commands.

Once that's done, I'll merge your PR.

@LaurentRDC LaurentRDC merged commit 46e6d92 into LaurentRDC:master Oct 25, 2023
4 checks passed
@LaurentRDC
Copy link
Owner

I'll be cleaning up the PR directly in the master branch.

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support asymptote diagrams
2 participants