We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The unit of the reciprocal lattice vector that is used in the function powdersim is expected to be 1/Å. (see the documentation).
powdersim
The unit of $q$ in fact is $2\pi$/Å.
I illustrated this issue in a jupyter notebook, where the result of scikit-ued is compared with the output of py4DSTEM.
The text was updated successfully, but these errors were encountered:
You are right. The units of q can be inferred from the units of crystals.Lattice.reciprocal_vectors: https://github.com/LaurentRDC/crystals/blob/master/crystals/lattice.py#L145
crystals.Lattice.reciprocal_vectors
I will update the documentation shortly.
Sorry, something went wrong.
Fixed a documentation issue where arguments of powdersim did not ha…
1eb8dd4
…ve the right units (#44)
The correct units are now reported, and version 2.1.14 will contain the corrected documentation.
Thanks for catching this bug!
No branches or pull requests
Version / Platform Info
Expected Behavior
The unit of the reciprocal lattice vector that is used in the function
powdersim
is expected to be 1/Å. (see the documentation).Actual Behavior
The unit of$q$ in fact is $2\pi$ /Å.
Minimal Example of Issue
I illustrated this issue in a jupyter notebook, where the result of scikit-ued is compared with the output of py4DSTEM.
The text was updated successfully, but these errors were encountered: