Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powdersim reciprocal lattice vector normalization issue #44

Closed
1 of 3 tasks
grahamsno opened this issue Mar 17, 2023 · 2 comments
Closed
1 of 3 tasks

powdersim reciprocal lattice vector normalization issue #44

grahamsno opened this issue Mar 17, 2023 · 2 comments

Comments

@grahamsno
Copy link

Version / Platform Info

  • scikit-ued Version: 2.1.13
  • Happens in latest version? (Yes/No): Yes
  • Known Operating System(s) affected:
    • Windows
    • Linux
    • Mac OS

Expected Behavior

The unit of the reciprocal lattice vector that is used in the function powdersim is expected to be 1/Å. (see the documentation).

Actual Behavior

The unit of $q$ in fact is $2\pi$/Å.

Minimal Example of Issue

I illustrated this issue in a jupyter notebook, where the result of scikit-ued is compared with the output of py4DSTEM.

@LaurentRDC
Copy link
Owner

LaurentRDC commented Mar 18, 2023

You are right. The units of q can be inferred from the units of crystals.Lattice.reciprocal_vectors: https://github.com/LaurentRDC/crystals/blob/master/crystals/lattice.py#L145

I will update the documentation shortly.

LaurentRDC added a commit that referenced this issue Mar 18, 2023
@LaurentRDC
Copy link
Owner

The correct units are now reported, and version 2.1.14 will contain the corrected documentation.

Thanks for catching this bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants