feat: wrap payload in envelope #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naugtur
commented
Jan 22, 2024
| "webpack-dev-server": "4.15.1" | ||
| "webpack-dev-server": "4.15.1", | ||
| "react": "^16.12.0", | ||
| "react-dom": "^16.12.0" |
There was a problem hiding this comment.
they didn't get installed by default. for the build to work we need to have these as dev deps
naugtur
commented
Feb 7, 2024
Comment on lines
+28
to
+30
| const payload = STORE.get(envelope); | ||
| lavadome.current.envelope(payload); | ||
| }, [envelope]); |
There was a problem hiding this comment.
Suggested change
| const payload = STORE.get(envelope); | |
| lavadome.current.envelope(payload); | |
| }, [envelope]); | |
| lavadome.current.envelope(envelope); | |
| }, [envelope]); |
Sorry, missed this one when refactoring.
|
migrated to #26 |
This was referenced Feb 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent the secret string from being cached all over the place by react and made public, wrap the string in an envelope where there's no way to retrieve the contents without being the implementer of the envelope.