Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync issues with RemoteStorage #377

Closed
bnjbvr opened this issue Feb 1, 2016 · 6 comments
Closed

Sync issues with RemoteStorage #377

bnjbvr opened this issue Feb 1, 2016 · 6 comments

Comments

@bnjbvr
Copy link
Contributor

bnjbvr commented Feb 1, 2016

Hi,

I've been using Laverna with RemoteStorage sync for more than a month and I am quite happy so far :-)
I do see some synchronization issues sometimes, though:

  • on computer A, I create a note x.
  • on computer B, I sync, change content of note x and move it to another notebook.
  • on computer A, note x's content hasn't changed, nor has it moved.

That's a bit annoying, because it also makes notes "reappear" from trash, etc. It's not a deal breaker though; I keep on using Laverna on the same machine and these problems don't happen, but that kinda breaks the spirit of sync :-)

Nothing weird seems to appear on the JavaScript developer console.
Please let me know if I can provide further information.
Cheers!

@wwebfor wwebfor added the bug label Feb 1, 2016
@wwebfor wwebfor added this to the 1. Refactor and fix bugs milestone Feb 1, 2016
@wwebfor
Copy link
Member

wwebfor commented Feb 1, 2016

Yeah, it still needs to be improved. Currently we are working on improving encryption. We'll try to find out what's happening later.

wwebfor added a commit that referenced this issue Feb 2, 2016
* Fix sync issues with RemoteStorage #373, #377, #279
* Fix re-encryption bugs (set encryptedData key to null)
@wwebfor
Copy link
Member

wwebfor commented Feb 9, 2016

Can the issue be closed? It seems like you fixed it :)

@wwebfor wwebfor added fixed and removed bug labels Feb 9, 2016
@bnjbvr
Copy link
Contributor Author

bnjbvr commented Feb 9, 2016

I am a bit unsure about one thing: what happens when an object is completely deleted from machine A? I do think that if it's still live on machine B, machine B is going to re-create it (as it's not on the remote's storage backend), and I'd like to make sure this doesn't happen. Or I could open a different issue, only if needed :-)

@wwebfor
Copy link
Member

wwebfor commented Feb 9, 2016

You're right. We haven't tested the removal. I think if an object is removed, it is going to sync it with empty values. Because when an object is removed, the app makes all values of the item empty.

@wwebfor
Copy link
Member

wwebfor commented Feb 10, 2016

@bnjbvr we've just received bounty from 5apps for fixing bugs with RemoteStorage. Since you worked on fixing them too, we are eager to share that bounty with you. If you are interested, you can send us your Bitcoin address :)

@bnjbvr
Copy link
Contributor Author

bnjbvr commented Feb 11, 2016

Nice, thank you! I've just sent you my bitcoin address to your email address mentioned on Github. Cheers!

@wwebfor wwebfor closed this as completed Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants