Correct versionCode semantic #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasanglass
approved these changes
May 4, 2024
Goooler
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On Lawnchair Launcher 12.1 Alpha 4, we use 12_01_00_05 (
12010005), However on Lawnchair Launcher 14 Beta 2 we reverted to just 14 (right now it's actually 15 but let's assume it was correct) thus making the upgrade from 12.1 Alpha 4 to 14 Beta 2 impossible.Right now I have no idea which format are we using because LC 12.1 A4 uses
12010005(what does the 5 stand for?) so I just created one.Lawnchair Launcher 14 Beta 2 - 14_00_02_02 (14000202)
The graphic does not show Field 2 (Android Minor)
Semantic (from my point of view)
Fixes
Fixes Issues (populated as of May 4th 2024)
Fixes IzzyOnDroid Publishing
Type of change
❌ General change (non-breaking change that doesn't fit the below categories like copyediting)
✅ Bug fix (non-breaking change which fixes an issue)
❌ New feature (non-breaking change which adds functionality)
❌ Breaking change (fix or feature that would cause existing functionality to not work as expected)
Fixes #4341
Fixes #4325