fix checklist rendering in pr template #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone tell me what effect you plan to achieve with this? It's understandable that people will check the checkboxes without reading, but now you can rebuke them for not reading. Just why? I don't see the point of adding unnecessary actions to the dozens of actions you have to take to create and suggest an icon. I understand when everyone tries to make the process easier, not more complicated. 🙂 |
|
Please leave discussion regarding the checkboxes in #1413. This PR doesn't add the checkboxes, it only fixes them. (Tbh, I don't feel like checking a box adds additional effort. It's a better reminder than a comment.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the checklist in the pr template used
[x] ...Type of change
❌ Bug fix (non-breaking change which fixes an issue)
✅ General change (non-breaking change that doesn't fit the above categories, such as copyediting)