Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize icon paths #1548

Merged
merged 8 commits into from
Nov 4, 2023
Merged

Optimize icon paths #1548

merged 8 commits into from
Nov 4, 2023

Conversation

KTibow
Copy link
Contributor

@KTibow KTibow commented Nov 4, 2023

Sorry for so many PRs but I just keep finding ways to optimize SVGs.
For easy viewing, before and after:
before
after
This autogenerated diff may help. Don't get too freaked out over the fact that icons changed in an "optimize" pr, go to the specific icon in the diff and see how different it is yourself.
88bfc338-7b3b-4184-8979-1399487c7155_diff
-14.6 kilobytes from the apk

@KTibow KTibow marked this pull request as ready for review November 4, 2023 19:20
@x9136
Copy link
Collaborator

x9136 commented Nov 4, 2023

@KTibow The picture speeds things up, though you have to search for a title additionally.

Icons where elements are missing

Screenshot 2023-11-05 at 00 00 12
bandido.svg

Screenshot 2023-11-05 at 00 01 42
bitrix24.svg

Screenshot 2023-11-05 at 00 03 04
google_play_games.svg

@x9136 x9136 merged commit dfa3ab0 into LawnchairLauncher:develop Nov 4, 2023
3 checks passed
@service-paradis service-paradis mentioned this pull request Nov 30, 2023
3 tasks
@x9136
Copy link
Collaborator

x9136 commented Jan 28, 2024

Screenshot 2024-01-28 at 15 03 52

I focused on the comparison from the description, since PRs with >350 icons take a long time to load, and you have to load too many icons manually. As a result, I missed moshidon.svg, which is not in the comparison, but is in the PR. And, for example, meduza.svg is in the comparison, but it is not in the PR.

@KTibow If you make comparisons in the future, please make sure that they contain all the icons from a PR.

@KTibow
Copy link
Contributor Author

KTibow commented Jan 28, 2024

I honestly have no idea why it didn't include that icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants