Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+1 icon #2155

Merged
merged 3 commits into from
Jun 15, 2024
Merged

+1 icon #2155

merged 3 commits into from
Jun 15, 2024

Conversation

Ahmed-Khalifa
Copy link
Contributor

Added

Team Pixel Wallpapers (com.lagguy.teampixelwallpapers/com.amaan.app.features.MainActivity)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

* Team Pixel Wallpapers (`com.lagguy.teampixelwallpapers/com.amaan.app.features.MainActivity`)
Copy link
Contributor

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the original name is not in English, then add a localized (or transliterated) one to it using ~~.
    Example: フールー ~~ Hulu.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center.
  3. Avoid blackness or noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Jun 13, 2024
Copy link
Contributor Author

@Ahmed-Khalifa Ahmed-Khalifa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly approve.
Can you help me with how to use "git reset --hard" command if you have time to explain?

svgs/teampixel.svg Outdated Show resolved Hide resolved
app/assets/appfilter.xml Show resolved Hide resolved
@x9136
Copy link
Collaborator

x9136 commented Jun 14, 2024

Can you help me with how to use "git reset --hard" command if you have time to explain?

As far as I remember, this topic helped me: https://stackoverflow.com/questions/50112363/how-to-fix-your-branch-is-ahead-of-origin-master-by-1-commit.

My process is like this:

  1. I'm doing "Fetch origin" in GitHub Desktop.
  2. I open the console and write git reset --hard upstream/develop. As far as I understand, this allows me to synchronize the main repository (LawnchairLauncher:develop) with my local copy.
  3. After that, I do "Force push origin" in GitHub Desktop. This allows me to replace the content of my branch with the content of my local copy. As a result, my branch turns out to be the same as the main repository.

Perhaps I also configured through the console what GitHub Desktop will consider the main repository. But it's kind of easy to google.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Jun 14, 2024
@x9136 x9136 merged commit b7d912c into LawnchairLauncher:develop Jun 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants