Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+12 icons, +1 link, update 1 icon #2174

Merged
merged 12 commits into from
Jun 26, 2024
Merged

+12 icons, +1 link, update 1 icon #2174

merged 12 commits into from
Jun 26, 2024

Conversation

I21b
Copy link
Contributor

@I21b I21b commented Jun 22, 2024

Description

Added 12 icons, 1 link to Lawnicons, updated 1 icon in Lawnicons.

Icons addition information

Added

Aircade (top.arcadelink.app)
Banxo (com.caisseepargne.android.mobilebanking) ↗︎
Barquode (com.pranavpandey.matrix)
Bonjour RATP (com.fabernovel.ratp) ↗︎
Fandango (air.com.vudu.air.DownloaderTablet) ↗︎
Maimai Data (com.paperpig.maimaidata)
Rizline (com.PigeonGames.Rizline)
TagInfo (com.nxp.taginfolite)
TagWriter (com.nxp.nfc.tagwriter)
律动轨迹 ~~ Rizline (com.leiting.ldgj)
蓝牙遥控 ~~ Bluetooth control (com.android.superli.btremote)
菠萝包轻小说 ~~ SFAcg (com.sfacg)

Linked

Fandango (com.fandangofandango.svg)

Updated

PipePipe (InfinityLoop1309.NewPipeEnhanced)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Jun 22, 2024
Copy link
Contributor

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~.
    Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

@I21b I21b changed the title +5 icons +9 icons Jun 22, 2024
Copy link
Contributor Author

@I21b I21b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time making icons, so point out any mistakes!

@I21b I21b changed the title +9 icons +10 icons Jun 22, 2024
@I21b I21b changed the title +10 icons +10 icons, +1 link Jun 22, 2024
@I21b I21b changed the title +10 icons, +1 link +12 icons, +1 link Jun 22, 2024
app/assets/appfilter.xml Show resolved Hide resolved
svgs/fandango.svg Show resolved Hide resolved
svgs/maimai_data.svg Show resolved Hide resolved
svgs/banxo.svg Show resolved Hide resolved
svgs/taginfo.svg Show resolved Hide resolved
svgs/tagwriter.svg Show resolved Hide resolved
svgs/aircade.svg Show resolved Hide resolved
@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Jun 22, 2024
@I21b I21b changed the title +12 icons, +1 link +12 icons, +1 link, update 1 icon Jun 22, 2024
@I21b I21b requested a review from x9136 June 22, 2024 22:19
svgs/pipepipe.svg Show resolved Hide resolved
svgs/fandango.svg Show resolved Hide resolved
svgs/tagwriter.svg Show resolved Hide resolved
svgs/taginfo.svg Show resolved Hide resolved
@I21b I21b requested a review from x9136 June 26, 2024 05:16
svgs/fandango.svg Show resolved Hide resolved
svgs/taginfo.svg Show resolved Hide resolved
@I21b I21b requested a review from x9136 June 26, 2024 20:31
@x9136 x9136 merged commit a0488a7 into LawnchairLauncher:develop Jun 26, 2024
4 checks passed
@x9136 x9136 mentioned this pull request Jun 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants