Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nightly Releases #2267

Merged
merged 14 commits into from
Sep 18, 2024
Merged

Conversation

Hamster45105
Copy link
Contributor

@Hamster45105 Hamster45105 commented Aug 19, 2024

Description

Adds support for nightly releases on the repo. Most of the action is just copied from Lawnchair. I have tested it and it works on my fork.

I also improved the download section of the README

Closes #756

Type of change

❌ Bug fix (non-breaking change which fixes an issue)
✅ General change (non-breaking change that doesn't fit the above categories, such as copyediting)

@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 19, 2024
@x9136
Copy link
Collaborator

x9136 commented Aug 19, 2024

There is a broader discussion on the issue #756 than the nightly releases. This PR doesn't solve it.

@Hamster45105
Copy link
Contributor Author

There is a broader discussion on the issue #756 than the nightly releases. 

Maybe a seperate issue should be opened to discuss an automated stable release schedule seeing as the original author was asking for daily releases which this PR does fix...

If that's not suitable I will edit the description and remove the mention of the issue.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@x9136
Copy link
Collaborator

x9136 commented Sep 14, 2024

Is there any particular reason to split the stable and developer builds into sections?

I suggested removing this, because without sections, it is obvious where the stable builds are and where the developer builds are. It's like writing "enter here" near an input field.

@Hamster45105
Copy link
Contributor Author

Hamster45105 commented Sep 14, 2024

Is there any particular reason to split the stable and developer builds into sections?

When I organised it as you suggested with the note about the app ID, I thought it looked odd because the note has the same significance on the page as the development builds headings (both being in italics/bold), so it was hidden and less noticeable.

Here is what I'm trying to say:

Screenshot

@x9136
Copy link
Collaborator

x9136 commented Sep 14, 2024

It turns out that the whole template changes for the sake of the note, and not vice versa. I'll think about how to simplify it another time.

Although, for many reasons, life would hardly have changed without it. Therefore, the general question is: since stable versions do not update each other (let's say this is not feasible), does it make sense to take care of a small issue before it occurs? Lawnicons has been on Google Play for a couple of weeks now, but I haven't seen any questions here or on our socials like "why 2 apps were installed?". Lawnicons 2.12 may confirm or deny this.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@x9136 x9136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It remains a mystery why it is necessary to clarify an issue that users have no problem with.

@x9136 x9136 merged commit 8d6b60b into LawnchairLauncher:develop Sep 18, 2024
5 checks passed
@x9136 x9136 mentioned this pull request Sep 18, 2024
@x9136
Copy link
Collaborator

x9136 commented Sep 18, 2024

@Hamster45105 Obtainium links don't work. Can you confirm this?

If I remember correctly, everything worked a couple of weeks ago. The links need to be corrected or deleted.

@Hamster45105
Copy link
Contributor Author

@Hamster45105 Obtainium links don't work. Can you confirm this?

That's weird, they both work for me. What exactly isn't working?

@x9136
Copy link
Collaborator

x9136 commented Sep 18, 2024

That's weird, they both work for me. What exactly isn't working?

It seemed to me that it was possible to download an app from a computer in 2 clicks. It turns out that this is only a transition to the Obtainium app. Thanks for clarifying. There is no issue.

@Hamster45105 Hamster45105 deleted the nightly-releases branch September 18, 2024 23:08
twnesss pushed a commit to twnesss/lawnicons that referenced this pull request Oct 9, 2024
* Add support for nightly releases

* Add Google Play badge

* Simplify recommendation to use Lawnchair

* Add release.yml

* Update release headings wording

* Simplify README download section

* Reword Lawnchair version recommendation

* Revert some changes

* Add final newline to release.yml

* Formatting updates

* Simplify README download section (again)

* Simplify README download section (last time for real)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When is the next release? Set up CI job to create releases once a day?
3 participants