-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark stable classes and enable Compose Compiler reports #2280
Conversation
// Conflicts: // app/build.gradle.kts // app/src/main/kotlin/app/lawnchair/lawnicons/ui/components/home/IconPreviewGrid.kt
// Conflicts: // app/src/main/kotlin/app/lawnchair/lawnicons/ui/destination/Contributors.kt // app/src/main/kotlin/app/lawnchair/lawnicons/ui/destination/Home.kt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific advantage/reason to mark these classes as stable instead of using kotlinx.collections.immutable.*
?
Compose treats immutable collections as stable, now we can mark normal collections stable instead. This will also ensure Compose's smart skipping works efficiently and reduce our package size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for clarifying.
…ncher#2280) * Remove org.jetbrains.kotlinx:kotlinx-collections-immutable * Enable stabilityConfigurationFile and reportsDestination https://developer.android.com/develop/ui/compose/performance/stability/fix#configuration-file
https://developer.android.com/develop/ui/compose/performance/stability/fix#configuration-file