Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+12 icons, +3 link #2315

Merged
merged 8 commits into from
Sep 12, 2024
Merged

+12 icons, +3 link #2315

merged 8 commits into from
Sep 12, 2024

Conversation

I21b
Copy link
Contributor

@I21b I21b commented Sep 9, 2024

Description

Icons addition information

Added

BBLL (com.package.app)
BiliYou (com.lucinhu.bili_you)
BUFF (com.netease.buff)
СберИнвестиции ~~ SberInvestments (ru.sberbank.investor) ↗︎
Купер ~~ Kuper (ru.instamart) ↗︎
Magical Search (com.magicalstory.search)
magicplan (com.sensopia.magicplan)
Moscow Wi-Fi autologin (pw.thedrhax.mosmetro) ↗︎
О'КЕЙ ~~ O'KEY (ru.reksoft.okey) ↗︎
РЖД Пассажирам билеты на поезд ~~ Russian Railways (ru.rzd.pass) ↗︎
TorrServe MatriX (ru.yourok.torrserve)
Перекресток ~~ Perekrestok (ru.perekrestok.app) ↗︎
乐速通 ~~ BJETC (com.bjetc.mobile)

Linked

Avee Player Lite (com.daaw.avee.lite → avee_music_player.svg)
BUFF (com.netease.buff163 → buff.svg)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024 •
edited by x9136
Loading

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.
  • Approved by the Lawnicons reviewer

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.
  • Approved by the Lawnicons reviewer

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.
  • Approved by the Lawnicons reviewer

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.
  • Approved by the Lawnicons reviewer

@I21b
Copy link
Contributor Author

I21b commented Sep 9, 2024

#2285 @astolfogit

x9136
x9136 requested changes Sep 10, 2024
View reviewed changes
svgs/kuper.svg Outdated Show resolved Hide resolved
svgs/buff.svg Outdated Show resolved Hide resolved
svgs/magical_search.svg Outdated Show resolved Hide resolved
svgs/russian_railways.svg Outdated Show resolved Hide resolved
svgs/torrserve_matrix.svg Outdated Show resolved Hide resolved
svgs/okey.svg Outdated Show resolved Hide resolved
app/assets/appfilter.xml Outdated Show resolved Hide resolved
@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Sep 10, 2024
@x9136
Copy link
Collaborator

x9136 commented Sep 10, 2024

If you plan to refine the icons, then try to figure out how to do this by updating the PR, rather than creating a new one.

@I21b
Copy link
Contributor Author

I21b commented Sep 10, 2024

If you plan to refine the icons, then try to figure out how to do this by updating the PR, rather than creating a new one.

checks will fail after force-push :(

@I21b
Copy link
Contributor Author

I21b commented Sep 10, 2024

fix in weekend

@I21b @fishaffair
@tighnaridotme @SuperDragonXD
+12 icons, +3 link
56cbf23 
> Icons: `BBLL`, `BiliYou`, `BUFF`, `СберИнвестиции ~~ SberInvestments`, `Купер ~~ Kuper`, `Magical Search`, `magicplan`, `Moscow Wi-Fi autologin`, `О'КЕЙ ~~ O'KEY`, `РЖД Пассажирам билеты на поезд ~~ Russian Railways`, `Перекресток ~~ Perekrestok`, `乐速通 ~~ BJETC`
> Links: `Avee Player Lite`, `BUFF`, `TorrServe MatriX`

Co-Authored-By: Daniil <[email protected]>
Co-Authored-By: astolfogit <[email protected]>
Co-Authored-By: OWQW <[email protected]>
Co-Authored-By: 92 <[email protected]>
@SuperDragonXD
Copy link
Contributor

checks will fail after force-push :(

It's fine for the send-notifications check to fail; the only required ones for merging are build-debug-apk and check-style.

@I21b I21b requested a review from x9136 September 11, 2024 16:20
@I21b

This comment was marked as resolved.

Sign in to view
@I21b

This comment was marked as resolved.

Sign in to view
@x9136 x9136 merged commit ed6393e into LawnchairLauncher:develop Sep 12, 2024
4 checks passed
twnesss pushed a commit to twnesss/lawnicons that referenced this pull request Oct 9, 2024
@I21b @fishaffair
@tighnaridotme @SuperDragonXD @x9136 @twnesss
+12 icons, +3 link (LawnchairLauncher#2315)
76c7a48 
* +12 icons, +3 link

> Icons: `BBLL`, `BiliYou`, `BUFF`, `СберИнвестиции ~~ SberInvestments`, `Купер ~~ Kuper`, `Magical Search`, `magicplan`, `Moscow Wi-Fi autologin`, `О'КЕЙ ~~ O'KEY`, `РЖД Пассажирам билеты на поезд ~~ Russian Railways`, `Перекресток ~~ Perekrestok`, `乐速通 ~~ BJETC`
> Links: `Avee Player Lite`, `BUFF`, `TorrServe MatriX`

Co-Authored-By: Daniil <[email protected]>
Co-Authored-By: astolfogit <[email protected]>
Co-Authored-By: OWQW <[email protected]>
Co-Authored-By: 92 <[email protected]>

* small fix

* Update buff.svg

* Update okey.svg

* Update torrserve_matrix.svg

---------

Co-authored-by: Daniil <[email protected]>
Co-authored-by: astolfogit <[email protected]>
Co-authored-by: OWQW <[email protected]>
Co-authored-by: SuperDragonXD <[email protected]>
Co-authored-by: Gleb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@x9136 x9136 Awaiting requested review from x9136

Assignees
No one assigned
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@I21b @x9136 @SuperDragonXD