Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+7 icons, +1 link #2337

Closed
wants to merge 1 commit into from
Closed

+7 icons, +1 link #2337

wants to merge 1 commit into from

Conversation

iysr
Copy link

@iysr iysr commented Sep 15, 2024

Description

Added 7 icons, linked 1 icon.

Icons addition information

Added

YouTrip (co.you.youapp/co.you.youapp.ui.magiclink.MagicLinkActivity)
Trust Bank (sg.trust/sg.phoenix.features.splash.SplashActivity)
FairPrice Group (com.fairprice.mcomapp/sg.nedigital.everythingfood.landing.features.splash.JcSplashScreenActivity)
yuu (com.tomoloyalty.yuu/com.tomoloyalty.yuu.MainActivity)
Singpass (sg.ndi.sp/sg.ndi.activity.DashBoardActivity)
CNA (com.channelnewsasia/com.channelnewsasia.ui.MainActivity)
SC Mobile (air.app.scb.breeze.android.main.sg.prod/air.app.scb.breeze.android.main.sg.prod.launcher_a189f323b82c4f1d56b76ce42119a72687c34991e481c56f912901e9a99bf3fb)

Linked

CIMB Clicks (com.cimb.sg.clicksMobile/com.cimb.sg.clicksMobile.MainActivitycimb_bank_ph.svg)

Contributor's checklist

  • I followed the Lawnicons guidelines and will make changes if someone suggests. I will also make sure that Lawnicons builds correctly.

Copy link
Contributor

Thanks for your contribution!

While waiting for a review from our team, you can do a self-review to ensure that your icons are suitable for Lawnicons. We try to do the review within 7 days.

Canvas and sizes

  1. Canvas: 192×192px.
  2. Non-square icons: the long side of the icons should be 160px.
  3. Square icons: 154×154px.

Color, stroke width and rounding

  1. Color: non-transparent black #000.
  2. No fill. Base stroke width: 12px. 14px, 10px, 8px — depending on the shape of the icons. 6px — for fine details.
  3. Rounded ends and joins. 90° corners are rounded by 6-32px.

Naming

  1. Names should match the official app name and contain no additional text.
  2. If the first 3 characters of the app name contain letters not from the English alphabet, then add a localized (or transliterated) name via ~~. Example: 京东 ~~ JD.
  3. The names of the drawables should repeat the names of the apps if nothing prevents it.

Quality

  1. Ensure that icons are easily recognizable.
  2. Align icons to the visual center as much as possible within the guidelines. The visual center is where your icon looks and feels centered.
  3. Avoid noticable black spots by reducing the stroke width or simplifying the icons.
  4. Avoid close distances between strokes. The icons on the phone screen will be smaller, so the small distances between the strokes will stick together.
  5. Avoid drastic changes in stroke widths. When the strokes next to each other differ in width by 4px or more, the icon will look sloppy.

@github-actions github-actions bot added the icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. label Sep 15, 2024
@x9136
Copy link
Collaborator

x9136 commented Sep 15, 2024

Only "yuu" icon is almost suitable, except for the quality requirements. The rest of the icons are far from the Lawnicons guidelines.

If you plan to fix the icons, I suggest you focus on the comment above, which briefly describes all the points of the Lawnicons guidelines. Also avoid masks when creating icons, otherwise such icons will have jagged lines on a phone screen.

@x9136 x9136 added the rework The team has requested changes in the issue or PR. label Sep 15, 2024
@iysr iysr closed this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icons This PR modifies Lawnicons by adding, removing, or mapping an icon to a SVG. rework The team has requested changes in the issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants