-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically release version #2422
base: develop
Are you sure you want to change the base?
Automatically release version #2422
Conversation
Signed-off-by: validcube <[email protected]>
Signed-off-by: validcube <[email protected]>
Hey!
|
Signed-off-by: validcube <[email protected]>
…ocumentation Signed-off-by: validcube <[email protected]>
Signed-off-by: validcube <[email protected]>
Signed-off-by: validcube <[email protected]>
The script will do automated release validation on the first day of each month. It checks if there are over 100 new icons in the develop branch by comparing the latest commits to the previous release tag. If this threshold is met and it’s the first run of the day, the release will be greenlit for publishing (unless the workflow is manually triggered). https://www.figma.com/slides/KR4epX0MZpr34CmPHGmox8/auto-release?node-id=0-21&t=KfGiLKv5A6DpnnlT-1 On the technical side, the script is overengineered to support GitHub Actions, GitLab CI, and Forgejo; complete with documentation (could be jarring). It doesn't work on CI yet as I don't know how to push script results to env |
Signed-off-by: validcube <[email protected]>
Signed-off-by: validcube <[email protected]>
Signed-off-by: validcube <[email protected]>
I wonder what will happen to Lawnicons Nightly after the automatic release. |
Signed-off-by: validcube <[email protected]>
I'm sure that Nightly and automatic release can work together. Lawnicons Nightly will always be the canary branch built daily for users to test out features or (mostly) icons. While automated release will release a new stable version of Lawnicons every month when ready. This is up to you, but personally, I think Nightly isn't needed, we can release pre-releases for testing as needed by manually triggering the workflow once. |
I suggest using this template for automatic releases.
|
I've also been thinking about how it's useful. If you added icons that were missing, or someone added them for you, then the easiest way to install the icons is to download *.apk. There is little point in waiting for the stable release in this case. At the same time, the nighly.link zip-file has several disadvantages. I regularly see how different people give positive reactions to the Lawnicons nightly release. |
Description
Do I have any idea what i'm doing?? no I don'tttt, this python script is running me insane, i'll likely update the description of this pr to be more descriptive but for now this is plain stupid
Note
The script work, but I can't get python to output to env yet
Icon count
Greenlight check
Version Predictor TM
Type of change
❌ Bug fix (non-breaking change which fixes an issue)
✅ General change (non-breaking change that doesn't fit the above categories, such as copyediting)