Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.2.4 can't resolve default pathname with index.js like v2.2.3 can #106

Closed
viT-1 opened this issue May 31, 2021 · 1 comment
Closed

v2.2.4 can't resolve default pathname with index.js like v2.2.3 can #106

viT-1 opened this issue May 31, 2021 · 1 comment

Comments

@viT-1
Copy link

viT-1 commented May 31, 2021

My repo for testing case
with npm run deploy.dev v2.2.3 resolves imports in dist/main.js as
import { GreeterUse } from "./common.blocks/GreeterUse/index.js";
but v2.2.4 as
import { GreeterUse } from "./common.blocks/GreeterUse.js";
nonara added a commit that referenced this issue Jun 16, 2021
@nonara
feat: Rewrote resolution strategy + various improvements (see notes)
64881a8 
- Several improvements were made for speed and efficiency.
- Now accommodating for new TS empty baseURL provision (closes #109)
- Pre-checking necessity before overwriting paths (closes #110)
- Rewrote core resolution methodology to:
  - Properly handle implicit indexes (closes #106)
  - Properly handle implicit sub-package indexes set via package.json 'main' #108)
  - Not follow symlinks (#107)
  - Resolve from output path as opposed to SourceFile path (#103)
nonara added a commit that referenced this issue Jun 16, 2021
@nonara
feat: Rewrote resolution strategy + various improvements (see notes)
1c07bfb 
- Several improvements were made for speed and efficiency.
- Now accommodating for new TS empty baseURL provision (closes #109)
- Pre-checking necessity before overwriting paths (closes #110)
- Rewrote core resolution methodology to:
  - Properly handle implicit indexes (closes #106)
  - Properly handle implicit sub-package indexes set via package.json 'main' #108)
  - Not follow symlinks (#107)
  - Resolve from output path as opposed to SourceFile path (#103)
nonara added a commit that referenced this issue Jun 16, 2021
@nonara
feat: Rewrote resolution strategy + various improvements (see notes)
c373d76 
- Several improvements were made for speed and efficiency.
- Now accommodating for new TS empty baseURL provision (closes #109)
- Pre-checking necessity before overwriting paths (closes #110)
- Rewrote core resolution methodology to:
  - Properly handle implicit indexes (closes #106)
  - Properly handle implicit sub-package indexes set via package.json 'main' #108)
  - Not follow symlinks (#107)
  - Resolve from output path as opposed to SourceFile path (#103)
@nonara nonara closed this as completed in ed1df79 Jun 16, 2021
@nonara
Copy link
Collaborator

nonara commented Jun 16, 2021

Thanks for the report, and sorry about the issue!

Please give v3.0 a try and let me know if you have any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nonara @viT-1