Skip to content
This repository has been archived by the owner on Sep 3, 2022. It is now read-only.

Progress #1366 -- Various TeleportID-related fixes #1367

Merged
merged 6 commits into from
Mar 25, 2022
Merged

Progress #1366 -- Various TeleportID-related fixes #1367

merged 6 commits into from
Mar 25, 2022

Conversation

Killfrra
Copy link
Contributor

@Killfrra Killfrra commented Mar 21, 2022

I wrote "progress" because I still have to use teleportation for collisions. Otherwise, collision avoidance comes into play and the minions go in different directions. They are already trying to do this, but in the indev branch they are teleported away every tick of the server. This also looks ugly, but I decided to keep this behavior.
At least now, instead of recalculating the entire path, a collision only changes the zero point of the path. And this is usually enough, because the collision only throws the unit back a little.

@Killfrra Killfrra changed the title Resolve #1366 -- Various TeleportID-related fixes Progress #1366 -- Various TeleportID-related fixes Mar 21, 2022
@Killfrra Killfrra marked this pull request as ready for review March 21, 2022 22:10
@Killfrra
Copy link
Contributor Author

By the way, using SetPosition On Collision will make progress with #1281

Copy link
Contributor

@lzardy lzardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good, however some emergent bugs will occur.

@lzardy lzardy merged commit 22dc5e4 into LeagueSandbox:indev Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants