-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid duplicate and useless checks #101
Conversation
Signed-off-by: Benoit Donneaux <[email protected]>
I've not found any existing documentation of our use of GitHub actions in this repository. |
Looking at the check results attached to this PR, it seems like the test has been run only once as requested. |
Please confirm if I correctly understand:
If so, then it is fine by me (we will need probably apply the same in few other repos: destiny, w-w) |
That is my understanding indeed. What might no longer work after this PR is the automatic run of the test when somebody pushes more commits in a pull_request that is already open.
That might depends on who the actions are organized in those repositories. We do not seem to have a standard approach. Let see how it works for this case first. |
@donpui, let's merge this PR once you'll have ticked (or not) the check-boxes in the description. |
That part might not be good, as we tend to push new commits/changes after review on PR. Manual actions depends too much depend on people and there is risk that we can merge something unverified. May be this can help: |
I'm testing different options in a sandbox repository (la-test/sbx-actions#27). |
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
Signed-off-by: Benoit Donneaux <[email protected]>
As suggested by @donpui, the use of skip-duplicate-actions seems to achieve our goal here (and likely in other repositories too). |
@donpui : can you have a second look here and tick the check-boxes in the description? |
As described in #94, we may want to avoid the integration test to run twice upon pull_request.
This PR introduce a pre-check to avoid duplicate test to be run on the same content.
In addition, this PR also provides:
Code Review Checklist (to be filled out by reviewer)