Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feedback api #123

Merged
merged 5 commits into from
Jan 17, 2023
Merged

Add feedback api #123

merged 5 commits into from
Jan 17, 2023

Conversation

JustusFT
Copy link
Contributor

@JustusFT JustusFT commented Jan 6, 2023

Ref: #118

Adds the feedback api as well as a dummy smtp server for testing to docker-compose.yml. Front end integration can be found at #124

Note the feedback-api submodule is pointing to LeastAuthority/feedback-api#6 which isn't merged

docker-compose.yml Outdated Show resolved Hide resolved
feedback-api/Dockerfile Outdated Show resolved Hide resolved
.gitmodules Outdated Show resolved Hide resolved
@JustusFT JustusFT requested a review from donpui January 12, 2023 03:39
@JustusFT JustusFT requested a review from donpui January 13, 2023 05:46
Copy link
Contributor

@donpui donpui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok now. Just thinking, should we merge this to main or to add-feedback-api-form branch (and when that is finished, merge both to main).

@JustusFT
Copy link
Contributor Author

We should merge this now, #124 can be merged later once it's ready

@JustusFT JustusFT merged commit 39028b7 into main Jan 17, 2023
@JustusFT JustusFT deleted the add-feedback-api branch January 17, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants