Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wasm bindings for go 1.19 #92

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix wasm bindings for go 1.19 #92

merged 1 commit into from
Nov 17, 2022

Conversation

JustusFT
Copy link

There was some changes to the js package between go 1.16 and 1.19. The Wrapper interface was removed in go 1.18 so the js side is not able to use the Promise type. To fix this, I changed the function to return a js.Value directly.


Code Review Checklist (to be filled out by reviewer)

  • Description accurately reflects what changes are being made.
  • Description explains why the changes are being made (or references an issue containing one).
  • The PR appropriately sized.
  • New code has enough tests.
  • New code has enough documentation to answer "how do I use it?" and "what does it do?".
  • Existing documentation is up-to-date, if impacted.

There was some changes to the `js` package between go 1.16 and 1.19.
The `Wrapper` interface was removed in go 1.18 so the js side is not
able to use the `Promise` type. To fix this, I changed the function to
return a `js.Value` directly.
@donpui donpui merged commit 4a6ad02 into master Nov 17, 2022
@donpui donpui deleted the go1.19-wasm-fix branch November 17, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants