Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add address test for all miniscript fragments #143

Closed
wants to merge 1 commit into from
Closed

Add address test for all miniscript fragments #143

wants to merge 1 commit into from

Conversation

bigspider
Copy link
Collaborator

Still following up on f9673ef, this adds a test that compares the generated addresses with the ones obtained from bitcoin-core for a set of descriptors that covers all miniscript fragments.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dab7df) 84.27% compared to head (5ccae90) 84.27%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #143   +/-   ##
========================================
  Coverage    84.27%   84.27%           
========================================
  Files           17       17           
  Lines         2168     2168           
========================================
  Hits          1827     1827           
  Misses         341      341
Flag Coverage Δ
unittests 84.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bigspider bigspider force-pushed the moretests branch 2 times, most recently from 6d18b15 to 4633d7d Compare September 7, 2023 09:20
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bigspider bigspider marked this pull request as ready for review September 7, 2023 14:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bigspider
Copy link
Collaborator Author

Changes from this PR included in #155.

@bigspider bigspider closed this Nov 3, 2023
@bigspider bigspider deleted the moretests branch November 3, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgliner-ledger sgliner-ledger Awaiting requested review from sgliner-ledger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigspider @codecov-commenter